Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Ensure callback arrays are unlocked when invoked and returning true #1589

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

VoidAwake
Copy link

@VoidAwake VoidAwake commented Oct 5, 2022

Description

In DelegateHelpers.InvokeCallbacksSafe_AnyCallbackReturnsTrue, returning true bypasses unlocking the callback array. This causes an error when a Player Input that has been auto switched is deleted, and then a Player Input Manager attempts to join a new player.

Changes made

Added a test to replicate the error, and then fixed the issue by ensuring the callback array is always unlocked before returning from InvokeCallbacksSafe_AnyCallbackReturnsTrue.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@unity-cla-assistant
Copy link

unity-cla-assistant commented Oct 5, 2022

CLA assistant check
All committers have signed the CLA.

@VoidAwake VoidAwake marked this pull request as ready for review October 5, 2022 10:07
@jfreire-unity jfreire-unity added the waiting-for-review The issue is scheduled to be reviewed by the Unity maintainers label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review The issue is scheduled to be reviewed by the Unity maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants